This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
feat: use Expo QR codes for Expo Go previews #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukmccall
approved these changes
Nov 26, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
## [1.2.0](1.1.0...1.2.0) (2021-11-26) ### New features * use Expo QR codes for Expo Go previews ([#9](#9)) ([4d9fe77](4d9fe77))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Is there a way to get the QR code images in PNG format? I admire you using SVG, but I want to post them to slack and they don't accept SVGs in their block-kit API. PS: Sorry for posting it here, I could not find the repository for the generateQRCode cloudfunction. |
|
@byCedric Is there a way to provide https://qr.expo.dev/ with a branch or channel name and have it automatically create a QR that links to the latest eas-update on that branch? If not, is there already a backlog item for this funtionality I can upvote? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
This implements "Expo QR codes" for Expo Go previews! The days that we have to abuse a poor 3rd party service for these QR codes are gone 😄
Additional context
You can see an example here, using this new code.